[PATCH] D11445: [zorg] Add lldb build factowqry that launches scripts on slave machine

Chaoren Lin chaorenl at google.com
Fri Jul 24 11:35:55 PDT 2015

chaoren added inline comments.

Comment at: zorg/buildbot/builders/LLDBBuilder.py:923
@@ +922,3 @@
+    getShellCommandStep(f, name='clean up',
+                        command=['cleanUp.bat'],
+                        haltOnFailure=False)
Is this for both Linux/OS X and Windows? On Linux/OS X, *.sh might be more appropriate. You can add another argument called 'scriptExtension' or something.

Comment at: zorg/buildbot/builders/LLDBBuilder.py:926
@@ +925,3 @@
+    # Get lldb-server binaries
+    if not buildAndroid:
We don't need this until we start testing. Could you move this between build and test?

Comment at: zorg/buildbot/builders/LLDBBuilder.py:943
@@ +942,3 @@
+    # Configure
+    getShellCommandStep(f, name='cmake local',
We can probably condense cleanup, checkout, and configure into one configure script. I don't think the first two steps would be useful to see separately.


More information about the llvm-commits mailing list