[PATCH] D11478: test-release.sh: Defer test errors until the end

Hans Wennborg hans at chromium.org
Fri Jul 24 09:16:19 PDT 2015


hans added inline comments.

================
Comment at: utils/release/test-release.sh:218
@@ +217,3 @@
+  Msg="$3"
+  echo "[${Flavor} Phase${Phase}] ${Msg}" >> $LogDir/deferred_errors.log
+}
----------------
dsanders wrote:
> Optional nit: If we're deferring full messages rather than just 'something failed' then I'd be inclined to echo to both stdout and the deferred error log. This allows you to search the main log for the message and find the origin of the failure.
Makes sense. Done.


http://reviews.llvm.org/D11478







More information about the llvm-commits mailing list