[PATCH] D11478: test-release.sh: Defer test errors until the end

Daniel Sanders daniel.sanders at imgtec.com
Fri Jul 24 08:48:21 PDT 2015


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM. I'll try the script over the weekend since I need to pick up the addition of libunwind too.


================
Comment at: utils/release/test-release.sh:218
@@ +217,3 @@
+  Msg="$3"
+  echo "[${Flavor} Phase${Phase}] ${Msg}" >> $LogDir/deferred_errors.log
+}
----------------
Optional nit: If we're deferring full messages rather than just 'something failed' then I'd be inclined to echo to both stdout and the deferred error log. This allows you to search the main log for the message and find the origin of the failure.


http://reviews.llvm.org/D11478







More information about the llvm-commits mailing list