[PATCH] D11407: [ARM] - Fix lowering of shufflevectors in AArch32

Renato Golin renato.golin at linaro.org
Thu Jul 23 03:59:54 PDT 2015

rengolin added a comment.

Hi Charlie,

The patch looks good to me, but it seems like it could do with some more tests. For example, you have undef for vext but not defined. And the other way around for vzip. You also changed vuzp masks, but haven't added double-size tests for them.

I'm expecting that the regular sized vtrn/vzip/vuzp tests are already somewhere else. Why did you create a new test for these? Why not just append on the existing one?



More information about the llvm-commits mailing list