[PATCH] D11340: [X86] Allow load folding into PUSH instructions

Michael Kuperstein michael.m.kuperstein at intel.com
Tue Jul 21 01:33:49 PDT 2015

mkuper added inline comments.

Comment at: test/CodeGen/X86/fold-push.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=i686-windows | FileCheck %s -check-prefix=CHECK -check-prefix=NORMAL
+; RUN: llc < %s -mtriple=i686-windows -mcpu=slm | FileCheck %s -check-prefix=CHECK -check-prefix=SLM
spatel wrote:
> Please check the feature flag directly rather than a CPU: -mattr=call-reg-indirect?
> Also, can this be loosened to -mtriple=i686-unknown-unknown? There's nothing Windows-specific here?
I'll change the feature flag, thanks.

And I'd prefer to leave windows, because the test is somewhat sensitive to the way the stack frame gets constructed. E.g. i686-pc-linux will not work. Given that, I'd rather not rely on unknown-unknown.


More information about the llvm-commits mailing list