[PATCH] D11340: [X86] Allow load folding into PUSH instructions

Sanjay Patel spatel at rotateright.com
Mon Jul 20 15:22:37 PDT 2015


spatel added inline comments.

================
Comment at: test/CodeGen/X86/fold-push.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=i686-windows | FileCheck %s -check-prefix=CHECK -check-prefix=NORMAL
+; RUN: llc < %s -mtriple=i686-windows -mcpu=slm | FileCheck %s -check-prefix=CHECK -check-prefix=SLM
+
----------------
Please check the feature flag directly rather than a CPU: -mattr=call-reg-indirect?

Also, can this be loosened to -mtriple=i686-unknown-unknown? There's nothing Windows-specific here?


http://reviews.llvm.org/D11340







More information about the llvm-commits mailing list