[llvm] r242725 - Remove duplicated code.

Rafael Espindola rafael.espindola at gmail.com
Mon Jul 20 15:41:44 PDT 2015


Author: rafael
Date: Mon Jul 20 17:41:44 2015
New Revision: 242725

URL: http://llvm.org/viewvc/llvm-project?rev=242725&view=rev
Log:
Remove duplicated code.

Both ELFObjectFile and ELFFile had an implementation of getLoadName.

Modified:
    llvm/trunk/include/llvm/Object/ELFObjectFile.h
    llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp

Modified: llvm/trunk/include/llvm/Object/ELFObjectFile.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELFObjectFile.h?rev=242725&r1=242724&r2=242725&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Object/ELFObjectFile.h (original)
+++ llvm/trunk/include/llvm/Object/ELFObjectFile.h Mon Jul 20 17:41:44 2015
@@ -318,7 +318,6 @@ public:
   uint8_t getBytesInAddress() const override;
   StringRef getFileFormatName() const override;
   unsigned getArch() const override;
-  StringRef getLoadName() const;
 
   std::error_code getPlatformFlags(unsigned &Result) const override {
     Result = EF.getHeader()->e_flags;
@@ -780,19 +779,6 @@ section_iterator ELFObjectFile<ELFT>::se
 }
 
 template <class ELFT>
-StringRef ELFObjectFile<ELFT>::getLoadName() const {
-  const Elf_Dyn *DI = EF.dynamic_table_begin();
-  const Elf_Dyn *DE = EF.dynamic_table_end();
-
-  while (DI != DE && DI->getTag() != ELF::DT_SONAME)
-    ++DI;
-
-  if (DI != DE)
-    return EF.getDynamicString(DI->getVal());
-  return "";
-}
-
-template <class ELFT>
 uint8_t ELFObjectFile<ELFT>::getBytesInAddress() const {
   return ELFT::Is64Bits ? 8 : 4;
 }

Modified: llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp?rev=242725&r1=242724&r2=242725&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp (original)
+++ llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp Mon Jul 20 17:41:44 2015
@@ -253,13 +253,13 @@ static std::error_code createDumper(cons
 
 static StringRef getLoadName(const ObjectFile *Obj) {
   if (auto *ELF = dyn_cast<ELF32LEObjectFile>(Obj))
-    return ELF->getLoadName();
+    return ELF->getELFFile()->getLoadName();
   if (auto *ELF = dyn_cast<ELF64LEObjectFile>(Obj))
-    return ELF->getLoadName();
+    return ELF->getELFFile()->getLoadName();
   if (auto *ELF = dyn_cast<ELF32BEObjectFile>(Obj))
-    return ELF->getLoadName();
+    return ELF->getELFFile()->getLoadName();
   if (auto *ELF = dyn_cast<ELF64BEObjectFile>(Obj))
-    return ELF->getLoadName();
+    return ELF->getELFFile()->getLoadName();
   llvm_unreachable("Not ELF");
 }
 





More information about the llvm-commits mailing list