[PATCH] D11307: Don't try to instrument allocas used by outlined SEH funclets

Reid Kleckner rnk at google.com
Mon Jul 20 15:42:21 PDT 2015


rnk marked an inline comment as done.
rnk added a comment.

thanks!


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:560
@@ -558,1 +559,3 @@
+  FunctionStackPoisoner(Function &F, AddressSanitizer &ASan,
+                        IntrinsicInst *LocalEscapeCall)
       : F(F),
----------------
samsonov wrote:
> You can find llvm.localescape in `FunctionStackPoisoner::visitIntrinsicInst` rather than pass it around.
Sure.

================
Comment at: test/Instrumentation/AddressSanitizer/localescape.ll:1
@@ +1,2 @@
+; RUN: opt < %s -asan -asan-module -asan-use-after-return -asan-stack-dynamic-alloca -S | FileCheck %s
+
----------------
eugenis wrote:
> Add a test without -asan-use-after-return?
> It should not be any different, but who knows.
> 
OK.


http://reviews.llvm.org/D11307







More information about the llvm-commits mailing list