[PATCH] Implement `internal_start/join_thread` on Mac OS X

Ismail Pazarbasi ismail.pazarbasi at gmail.com
Fri Jun 26 10:36:17 PDT 2015


================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:359
@@ +358,3 @@
+void *internal_start_thread(void(*func)(void *arg), void *arg) {
+#if TARGET_OS_MAC && !TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR
+  // Start the thread with signals blocked, otherwise it can steal user signals.
----------------
beanz wrote:
> samsonov wrote:
> > Please use SANITIZER_MAC, SANITIZER_IOSSIM and SANITIZER_IOS instead.
> You may not need these ifdefs at all. Does this work on the Simulator? I can't think of any reason why it wouldn't.
> 
> I've proposed adding experimental support for building iOS using CMake in D10710, and I expect this should all work on iOS too.
@samsonov Will do, if suggestion of @beanz doesn't work.

@beanz This is part of my TSan porting effort, and it seems like this function is called from TSan only. I haven't tried it on Simulator yet. I will try this patch, possibly without any `#if`s on Simulator, if Simulator is 64-bit. TSan requires 64-bit OS.

http://reviews.llvm.org/D9638

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list