[PATCH] [asan] Update the llvm webpage describing ASan

Alexander Potapenko glider at google.com
Mon Jun 22 09:56:55 PDT 2015


LGTM with a couple of nits.


================
Comment at: docs/AddressSanitizer.rst:69
@@ +68,3 @@
+* Fixing bugs becomes unavoidable. AddressSaniftizer does not produce
+  false alarms. Once a memory corruption occurs, the program is in an inconstant
+  state, which could lead to confusing results and potentially misleading
----------------
samsonov wrote:
> s/inconstant/inconsistent?
> 
"the program heap" instead of "the program", maybe?

================
Comment at: docs/AddressSanitizer.rst:78
@@ +77,3 @@
+re-exec.) Also keep in mind that when moving the executable to another machine,
+the asan library will also need to be copied over.
+
----------------
"the ASan library"

================
Comment at: docs/AddressSanitizer.rst:129
@@ +128,3 @@
+
+AddressSanitizer can optionally detect dynamic initialization order problems,
+when initialization of globals defined in one translation unit uses
----------------
IIRC this feature still doesn't work on OSX, shall we mention that?

================
Comment at: docs/AddressSanitizer.rst:192
@@ -124,3 +191,3 @@
 
-``__attribute__((no_sanitize_address))``
------------------------------------------------
+Disabling Instrumentation with ``__attribute__((no_sanitize_address))``
+-----------------------------------------------------------------------
----------------
What about `__attribute__((no_sanitize("address")))`?

================
Comment at: docs/AddressSanitizer.rst:251
@@ +250,3 @@
+* Linux i386/x86\_64 (tested on Ubuntu 12.04)
+* OS X 10.7 - 10.11 (i386/x86\_64)
+* Android ARM
----------------
Shall we reflect the current iOS port state?

http://reviews.llvm.org/D10559

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list