[PATCH] Value profiling - patchset 2 - merge intended

David Blaikie dblaikie at gmail.com
Fri Jun 19 22:06:13 PDT 2015

On Jun 19, 2015 6:54 PM, "Justin Bogner" <mail at justinbogner.com> wrote:
> Justin Bogner <mail at justinbogner.com> writes:
> > I've gone ahead and committed a clang-formatted version of this in
> > r240206.
> I had to revert this, as some bots were failing:
>   http://lab.llvm.org:8011/builders/sanitizer-windows/builds/5640
>   http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/5757
>   http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc/builds/7067
> On looking at the error it looks like you're move'ing from a vector that
> you've taken by reference. That seems pretty wrong. I guess you wanted
> an rvalue reference there?

It's correct(shouldn't error) to move from a non-const lvalue reference,
but yes, probably not good style/intended. Instead pass by value.

> Anyway, please look into the errors and send a patch that fixes the
> issues.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150619/e913d3bf/attachment.html>

More information about the llvm-commits mailing list