[PATCH] Value profiling - patchset 2 - merge intended
dblaikie at gmail.com
Fri Jun 19 22:06:13 PDT 2015
On Jun 19, 2015 6:54 PM, "Justin Bogner" <mail at justinbogner.com> wrote:
> Justin Bogner <mail at justinbogner.com> writes:
> > I've gone ahead and committed a clang-formatted version of this in
> > r240206.
> I had to revert this, as some bots were failing:
> On looking at the error it looks like you're move'ing from a vector that
> you've taken by reference. That seems pretty wrong. I guess you wanted
> an rvalue reference there?
It's correct(shouldn't error) to move from a non-const lvalue reference,
but yes, probably not good style/intended. Instead pass by value.
> Anyway, please look into the errors and send a patch that fixes the
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits