<p dir="ltr"><br>
On Jun 19, 2015 6:54 PM, "Justin Bogner" <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br>
><br>
> Justin Bogner <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> writes:<br>
> > I've gone ahead and committed a clang-formatted version of this in<br>
> > r240206.<br>
><br>
> I had to revert this, as some bots were failing:<br>
><br>
>   <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dwindows_builds_5640&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Q4RCO7uoDAc64-63epdP5Gdnsv4Ek1U-E0w_oTP4isI&s=yjW-vcOu9GH9cLkar4vuRpE6mXQHyq4tQxyrp8ZYuFc&e=">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/5640</a><br>
>   <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_lldb-2Dx86-2Dwin7-2Dmsvc_builds_5757&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Q4RCO7uoDAc64-63epdP5Gdnsv4Ek1U-E0w_oTP4isI&s=qTrGqU5GBe7tGOce1hHZ-G0ZKFrxm3d3x-36Sd9FgJU&e=">http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/5757</a><br>
>   <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_lldb-2Dx86-2Dwindows-2Dmsvc_builds_7067&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Q4RCO7uoDAc64-63epdP5Gdnsv4Ek1U-E0w_oTP4isI&s=f5cRqcnzYPEETNGi-uf97j5FHht-451F7m2l4QKxNHQ&e=">http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc/builds/7067</a><br>
><br>
> On looking at the error it looks like you're move'ing from a vector that<br>
> you've taken by reference. That seems pretty wrong. I guess you wanted<br>
> an rvalue reference there?</p>
<p dir="ltr">It's correct(shouldn't error) to move from a non-const lvalue reference, but yes, probably not good style/intended. Instead pass by value.</p>
<p dir="ltr">><br>
> Anyway, please look into the errors and send a patch that fixes the<br>
> issues.<br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>