[PATCH] [FaultMaps] Add a parser for the __llvm__faultmaps section.

[Sanjoy Das]

On Thu, Jun 18, 2015 at 5:51 PM, Joseph Tremoulet <jotrem at microsoft.com> wrote:
> LGTM, thanks.
>
>
> ================
> Comment at: tools/llvm-objdump/llvm-objdump.cpp:1241-1245
> @@ +1240,7 @@
> +    FaultMapSectionName = "__llvm_faultmaps";
> +  } else {
> +    errs() << "This operation is only currently supported "
> +              "for ELF and Mach-O executable files.\n";
> +    return;
> +  }
> +
> ----------------
> What's missing that will need to be implemented to support this on COFF?  (Not asking you to make any adjustments to this change; just saw this code and wondered about COFF.)

Nothing fundamental, since the binary format for __llvm_faultmaps
should remain target agnostic (modulo endianness).  I suppose you
could get support for COFF working by

 * teaching MCObjectFileInfo::initCOFFMCObjectFileInfo how to create a
COFF section for faultmaps

and

 * teaching printFaultMaps to pick the right COFF section to read

-- Sanjoy


>
> http://reviews.llvm.org/D10491
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>