[PATCH] [FaultMaps] Add a parser for the __llvm__faultmaps section.

Joseph Tremoulet jotrem at microsoft.com
Thu Jun 18 17:51:36 PDT 2015


LGTM, thanks.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1241-1245
@@ +1240,7 @@
+    FaultMapSectionName = "__llvm_faultmaps";
+  } else {
+    errs() << "This operation is only currently supported "
+              "for ELF and Mach-O executable files.\n";
+    return;
+  }
+
----------------
What's missing that will need to be implemented to support this on COFF?  (Not asking you to make any adjustments to this change; just saw this code and wondered about COFF.)

http://reviews.llvm.org/D10491

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list