[PATCH] LibDriver, llvm-lib: introduce.

[Rafael Espíndola]

On Jun 10, 2015 7:41 PM, "Rui Ueyama" <ruiu at google.com> wrote:
>
> Looks like I don't fully understand the patch... Is there any reason you
can't simply define a non-thread-safe virtual StringSaver.save(String) in
llvm and not define StringSaverBase? LLD can then override the function to
guard it with a mutex.
>

StringSaverBase is there to avoid the virtual destructor. Using it in a
method signature makes it explicit that that method doesn't destruct it
since the destructor is protected.

I can rename StringSaverBase to StringSaver and StringSaver to
StringSaverBumpPointer if you want.

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150611/a699e57b/attachment.html>