[PATCH] Allocate MCSymbol Name intrusively only when required

[Pete Cooper]

Thanks!  I committed this as r239423.

However, there was an issue on 32-bit targets because a pointer is less aligned than the uint64_t in MCSymbol.

I committed a quick fix to get the bots green in r239428.

Could you please take a look at that and see if its ok?  I’m ok with reverting the whole commit sequence too if you are particularly opposed to the fix.

Cheers,
Pete
> On Jun 9, 2015, at 10:44 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Looks good to me. Thanks!
> 
> On Tue, Jun 9, 2015 at 10:36 AM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Updated to NameEntryTy and *&.
> 
> 
> 
>> On Jun 8, 2015, at 2:41 PM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
>> 
>> 
>>> On Jun 8, 2015, at 2:39 PM, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
>>> 
>>> (though perhaps these names have precedence from the types you modeled them off, I'm not sure)
>> Not particularly.  NameEntryTy is a good name.
>> 
>> I like all the feedback.  Will update the patch accordingly.
>> 
>> Thanks,
>> Pete
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/0ce75daa/attachment.html>