<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks! I committed this as r239423.<div class=""><br class=""></div><div class="">However, there was an issue on 32-bit targets because a pointer is less aligned than the uint64_t in MCSymbol.</div><div class=""><br class=""></div><div class="">I committed a quick fix to get the bots green in r239428.</div><div class=""><br class=""></div><div class="">Could you please take a look at that and see if its ok? I’m ok with reverting the whole commit sequence too if you are particularly opposed to the fix.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Pete</div><div class=""><div><blockquote type="cite" class=""><div class="">On Jun 9, 2015, at 10:44 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Looks good to me. Thanks!<br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Jun 9, 2015 at 10:36 AM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">Updated to NameEntryTy and *&.</div><div class=""><br class=""></div><div class=""></div></div><br class=""><div style="word-wrap:break-word" class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 8, 2015, at 2:41 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>> wrote:</div><br class=""><div class=""><div style="word-wrap:break-word" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jun 8, 2015, at 2:39 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank" class="">dblaikie@gmail.com</a>> wrote:</div><br class=""><div class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:14px;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">(though perhaps these names have precedence from the types you modeled them off, I'm not sure)</span></div></blockquote>Not particularly. NameEntryTy is a good name.</div><div class=""><br class=""></div><div class="">I like all the feedback. Will update the patch accordingly.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete</div><br class=""></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div><br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>