[llvm] r239311 - Change MCSymbol IsELF to an enum to support future MCSymbolCOFF and MCSymbolMachO.

[Pete Cooper]

> On Jun 8, 2015, at 3:11 PM, Reid Kleckner <rnk at google.com> wrote:
> 
> On Mon, Jun 8, 2015 at 10:17 AM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> -  unsigned IsELF : 1;
> +  SymbolKind Kind : 2;
> 
> enums with MSVC are always signed unless you ask for something else, so this will cause sign extension and cast failure at runtime. I'm going to make this unsigned. 
Ah, sorry about that.  I’ll keep that in mind for later patches I have on this code.  There’s one more enum coming assuming the reviews go ok.

Thanks for fixing it.

Pete

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150608/d5f42e06/attachment.html>