<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 8, 2015, at 3:11 PM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 8, 2015 at 10:17 AM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- unsigned IsELF : 1;<br class="">
+ SymbolKind Kind : 2;</blockquote><div class=""><br class=""></div><div class="">enums with MSVC are always signed unless you ask for something else, so this will cause sign extension and cast failure at runtime. I'm going to make this unsigned. </div></div></div></div>
</div></blockquote>Ah, sorry about that. I’ll keep that in mind for later patches I have on this code. There’s one more enum coming assuming the reviews go ok.</div><div><br class=""></div><div>Thanks for fixing it.</div><div><br class=""></div><div>Pete</div><br class=""></body></html>