[PATCH] [Object, MachO] Don't crash on invalid MachO load commands.

[Alexey Samsonov]

I don't know, why should it?

llvm-objdump is not documented in http://llvm.org/docs/CommandGuide/, and
now the behavior of the tool is the same (return 0) for these invalid MachO
files and missing input files. I agree that we should probably decide and
document the behavior of the tool for invalid input, but that seems
orthogonal to this change - we just make all the possible failures in
constructor uniform.

On Wed, Jun 3, 2015 at 11:19 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> llvm-objdump should still exit with a non-zero status, no ?
>
> On 3 June 2015 at 21:31, Filipe Cabecinhas
> <filcab+llvm.phabricator at gmail.com> wrote:
> > (forgot to LGTM)
> >
> > LGTM, as long as the formatting change gets its own commit.
> >
> >
> > http://reviews.llvm.org/D10230
> >
> > EMAIL PREFERENCES
> >   http://reviews.llvm.org/settings/panel/emailpreferences/
> >
> >
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150604/ac1fc999/attachment.html>