<div dir="ltr">I don't know, why should it?<div><br></div><div>llvm-objdump is not documented in <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_CommandGuide_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=PhSc-x8UyAegvtGbMccfdxX7r5b4gw3xwedZH_jlBv4&s=sgdIVIKx8S5Q2v3PoSTqXbfA361o5tI5gBtSwWiSwIo&e=">http://llvm.org/docs/CommandGuide/</a>, and now the behavior of the tool is the same (return 0) for these invalid MachO files and missing input files. I agree that we should probably decide and document the behavior of the tool for invalid input, but that seems orthogonal to this change - we just make all the possible failures in constructor uniform.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 3, 2015 at 11:19 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">llvm-objdump should still exit with a non-zero status, no ?<br>
<br>
On 3 June 2015 at 21:31, Filipe Cabecinhas<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:filcab%2Bllvm.phabricator@gmail.com">filcab+llvm.phabricator@gmail.com</a>> wrote:<br>
> (forgot to LGTM)<br>
><br>
> LGTM, as long as the formatting change gets its own commit.<br>
><br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10230&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=PhSc-x8UyAegvtGbMccfdxX7r5b4gw3xwedZH_jlBv4&s=0f5PfRha_IdH3NABnVEyII5A3Ar6sQ1loi5M0A-UxRQ&e=" target="_blank">http://reviews.llvm.org/D10230</a><br>
><br>
> EMAIL PREFERENCES<br>
>   <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=PhSc-x8UyAegvtGbMccfdxX7r5b4gw3xwedZH_jlBv4&s=3f_4v1v4Hgsp0uq1ACaDyWyyR-BAB8_KQsgB2GE8oGA&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
><br>
><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div>