[PATCH] Move the name pointer off of Value

[Jim Grosbach]

While I rather like the change, I confess I have to agree with Chandler here that this went in a bit too quickly after the request for review. I’m agnostic on whether we need to revert first, but let’s definitely talk through the tradeoffs more fully either way.

Chandler, can you elaborate on what implications you don’t think are addressed and why you think this is such a significant change? It seems primarily a change of underlying implementation rather than a significant design question to me. You obviously feel differently.

-Jim

> On Jun 3, 2015, at 5:52 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> 
> Anyone there?
> 
> I'm still really unhappy at this going in, I don't think it's necessarily the right tradeoff at all.
> 
> On Mon, Jun 1, 2015 at 4:15 PM Chandler Carruth <chandlerc at gmail.com <mailto:chandlerc at gmail.com>> wrote:
> Uh, folks, please discuss this more widely before just committing. This is a really significant change and has implications you're not really addressing at all. Clang is not the only frontend and not the only producer of value names. With this change you'll likely cause a significant compile time hit for many folks.
> 
> 
> On Mon, Jun 1, 2015, 15:32 Owen Anderson <resistor at mac.com <mailto:resistor at mac.com>> wrote:
> r238791
> 
> 
> REPOSITORY
>   rL LLVM
> 
> http://reviews.llvm.org/D10173 <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10173&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=26qDWmL8gBboaPKdOiMoA-ifY1xERrSy7QnKohoJDXk&s=ZblcsXy226SymA6sk8oSsP6MIjuS1lef7pqq0IejGIo&e=>
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/ <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=26qDWmL8gBboaPKdOiMoA-ifY1xERrSy7QnKohoJDXk&s=oo6xx3n7I4knzO1tAB_fSlayqx3tK-E0jfAbf4yhkmM&e=>
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150603/7bce6da6/attachment.html>