<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">While I rather like the change, I confess I have to agree with Chandler here that this went in a bit too quickly after the request for review. I’m agnostic on whether we need to revert first, but let’s definitely talk through the tradeoffs more fully either way.<div class=""><br class=""></div><div class="">Chandler, can you elaborate on what implications you don’t think are addressed and why you think this is such a significant change? It seems primarily a change of underlying implementation rather than a significant design question to me. You obviously feel differently.</div><div class=""><br class=""></div><div class="">-Jim</div><div class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Jun 3, 2015, at 5:52 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Anyone there?<br class=""><br class="">I'm still really unhappy at this going in, I don't think it's necessarily the right tradeoff at all.<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Jun 1, 2015 at 4:15 PM Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr" class="">Uh, folks, please discuss this more widely before just committing. This is a really significant change and has implications you're not really addressing at all. Clang is not the only frontend and not the only producer of value names. With this change you'll likely cause a significant compile time hit for many folks.</p>
<br class=""><div class="gmail_quote">On Mon, Jun 1, 2015, 15:32 Owen Anderson <<a href="mailto:resistor@mac.com" target="_blank" class="">resistor@mac.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">r238791<br class="">
<br class="">
<br class="">
REPOSITORY<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10173&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=26qDWmL8gBboaPKdOiMoA-ifY1xERrSy7QnKohoJDXk&s=ZblcsXy226SymA6sk8oSsP6MIjuS1lef7pqq0IejGIo&e=" target="_blank" class="">http://reviews.llvm.org/D10173</a><br class="">
<br class="">
EMAIL PREFERENCES<br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=26qDWmL8gBboaPKdOiMoA-ifY1xERrSy7QnKohoJDXk&s=oo6xx3n7I4knzO1tAB_fSlayqx3tK-E0jfAbf4yhkmM&e=" target="_blank" class="">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></blockquote></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></div></body></html>