[PATCH] [Object, MachO] Make MachO parser significantly more robust to invalid inputs.
dblaikie at gmail.com
Fri May 29 11:45:19 PDT 2015
On Thu, May 28, 2015 at 6:55 PM, Keno Fischer <kfischer at college.harvard.edu>
> I don't really have a strong opinion either way, I just wanted to bring it
> up as last time I touched this file a strong preference for moving
> everything to ErrorOr was expressed in the review, because it's easy to
> ignore the std::error_code.
*nod* I'll +1 this idea, but I haven't looked at these APIs to see how
ingrained the options are. I also don't think there's a /huge/ cognitive
overload to some inconsistency here, so I'd be willing to pay some
inconsistency to move towards ErrorOr over error_code+out parameter.
> EMAIL PREFERENCES
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits