<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 28, 2015 at 6:55 PM, Keno Fischer <span dir="ltr"><<a href="mailto:kfischer@college.harvard.edu" target="_blank">kfischer@college.harvard.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I don't really have a strong opinion either way, I just wanted to bring it up as last time I touched this file a strong preference for moving everything to ErrorOr was expressed in the review, because it's easy to ignore the std::error_code.<br></blockquote><div><br>*nod* I'll +1 this idea, but I haven't looked at these APIs to see how ingrained the options are. I also don't think there's a /huge/ cognitive overload to some inconsistency here, so I'd be willing to pay some inconsistency to move towards ErrorOr over error_code+out parameter.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10111&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=7vONHrNkBpkvP6VP1TFrkqrWOfeiAKhoj8huC7i9JmE&s=hEkpgittFHGMZYQstEZbotwW2Ddztt2hAlsrz_41JbQ&e=" target="_blank">http://reviews.llvm.org/D10111</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=7vONHrNkBpkvP6VP1TFrkqrWOfeiAKhoj8huC7i9JmE&s=g0e0q-Xff0GZllF-VYqXnxW9u0vw6wSDNS5S19CgO1A&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>