[PATCH] Refactor debug info lexical block generation

[David Blaikie]

Perhaps it'd be good to have a general design discussion here, rather than
in the form of line-by-line code review. A few broad issues have been
brought up by both Paul and Frederic that sound reasonable to me, though
I've not looked at the code in detail yet.

Is there any reason this wouldn't be implemented the same way as the
imported entity work? Where we check for imported entities at scope
construction time to decide whether to create that scope or not.

On Sun, May 24, 2015 at 9:00 AM, Amjad Aboud <amjad.aboud at intel.com> wrote:

> Hi echristo, bkramer, dblaikie,
>
> This patch is needed for resolving Bug 19238.
> It is the first part which will be followed by D9758.
>
> The idea is to create all debug info lexical block DIEs and add them to
> the DIScope->DIE map.
> Latter, just before emitting the DIEs, we will search the DIE tree and
> collapse all redundant (useless) DIE lexical blocks.
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D9960
>
> Files:
>   include/llvm/CodeGen/DIE.h
>   lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
>   lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>   lib/CodeGen/AsmPrinter/DwarfDebug.h
>   test/DebugInfo/useless_lexical_scope.ll
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150527/12335172/attachment.html>