[PATCH] Fix 'leading zeros' caveat of StringRef::compare_numeric()
craig.topper at gmail.com
Wed May 27 08:26:33 PDT 2015
I believe it's current usage in TableGen I believe is to make record names come out in order like this.
I'm not sure it matters to support octal or hex in a context where it's embedded in string with letters in it. It would definitely be weird for hex.
For the tablegen use case I think if someone were to put in extra zeros in their tablegen recrds they would only do so to put a consistent number of digits in all records with a common prefix string. So I don't think supporting leading zeros gracefully is necessary.
More information about the llvm-commits