[PATCH] Fix 'leading zeros' caveat of StringRef::compare_numeric()

[Chandler Carruth]

This is a complex change to a routine with a strange and unclear interface and purpose.

In fact, this code is only called in one place that I can find outside of its unit tests: include/llvm/TableGen/Record.h. I'm not sure what that code is trying to do, but I don't think adding more complexity here to handle a corner case is the right path forward. I suspect that code should be rolling its own (hopefully *simpler* and more domain specific) logic and this method should just be deleted. But that doesn't really seem critically important either.

What I am confident in is that we shouldn't burn complexity and risk of bugs (or performance hits) on trying to make this function handle leading zeros particularly gracefully.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7388

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/