[PATCH] Refactor: Simplify boolean conditional return statements in lib/Transforms/Instrumentation

Evgeniy Stepanov eugenis at google.com
Tue May 26 10:40:51 PDT 2015


LGTM w/ a comment


================
Comment at: lib/Transforms/Instrumentation/ThreadSanitizer.cpp:325
@@ -324,3 +324,3 @@
     return SI->isAtomic() && SI->getSynchScope() == CrossThread;
   if (isa<AtomicRMWInst>(I))
     return true;
----------------
Please fold all three simple conditionals into the return statement.

http://reviews.llvm.org/D9996

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list