[PATCH] Refactor: Simplify boolean conditional return statements in lib/Transforms/IPO

Richard legalize at xmission.com
Mon May 25 10:41:08 PDT 2015


Hi nicholas, baldrick, void, sunfish, rafael, chandlerc, resistor,

Use clang-tidy to simplify boolean conditional return statements.

http://reviews.llvm.org/D9997

Files:
  lib/Transforms/IPO/Internalize.cpp

Index: lib/Transforms/IPO/Internalize.cpp
===================================================================
--- lib/Transforms/IPO/Internalize.cpp
+++ lib/Transforms/IPO/Internalize.cpp
@@ -124,10 +124,7 @@
     return false;
 
   // Marked to keep external?
-  if (ExternalNames.count(GV.getName()))
-    return false;
-
-  return true;
+  return !ExternalNames.count(GV.getName());
 }
 
 bool InternalizePass::runOnModule(Module &M) {

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9997.26462.patch
Type: text/x-patch
Size: 439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150525/a8660430/attachment.bin>


More information about the llvm-commits mailing list