[PATCH] [AArch64] Codegen VMAX/VMIN for safe math cases

Renato Golin renato.golin at linaro.org
Wed May 13 02:01:50 PDT 2015


On 12 May 2015 at 11:10, Artyom Skrobov <artyom.skrobov at arm.com> wrote:
> After James' patch with MIN/MAX intrinsics goes in, they can be extended to
> support floating-point min/max, and therefore to factor out this common code
> from ARM and AArch64 backends into somewhere shared and reusable.

This would be great. Is there a public review about this already?


> OK to commit?

Only one nitpick:

+  bool IsUnordered;
+  switch (CC) {
+  default: break;

IsUnordered is unused outside of the switch. It won't make any
difference to declare it just because both cases use it, as opposed to
declaring it on both.

Otherwise, LGTM. Feel free to commit with that change.

cheers,
--renato



More information about the llvm-commits mailing list