[PATCH] [DebugInfo] Add debug locations to constant SD nodes continued

Sergey Dmitrouk sdmitrouk at accesssoftek.com
Fri May 8 13:57:46 PDT 2015


On Fri, May 08, 2015 at 01:00:51PM -0700, David Blaikie wrote:
> How's about we just overload, then? (& assert that the right function is
> called for the right kinds of things? (ie: assert that the 3 arg (the one
> with DebugLoc) is called only for Constant/ConstantFP, and the 2 arg is
> called for non-Constant/ConstantFP? Would that make sense))

Not really :)  If we knew that this is neither Constant nor ConstantFP,
we could just call CSEMap directly.  The method was added to omit
checking opcode in all 40 places (only several callers have opcodes
nearby and could make correct decision which function to call, others
take opcode as one of their parameters).

-- 
Sergey



More information about the llvm-commits mailing list