[PATCH] [DebugInfo] Add debug locations to constant SD nodes continued

[David Blaikie]

On Fri, May 8, 2015 at 1:57 PM, Sergey Dmitrouk <sdmitrouk at accesssoftek.com>
wrote:

> On Fri, May 08, 2015 at 01:00:51PM -0700, David Blaikie wrote:
> > How's about we just overload, then? (& assert that the right function is
> > called for the right kinds of things? (ie: assert that the 3 arg (the one
> > with DebugLoc) is called only for Constant/ConstantFP, and the 2 arg is
> > called for non-Constant/ConstantFP? Would that make sense))
>
> Not really :)  If we knew that this is neither Constant nor ConstantFP,
> we could just call CSEMap directly.  The method was added to omit
> checking opcode in all 40 places (only several callers have opcodes
> nearby and could make correct decision which function to call, others
> take opcode as one of their parameters).
>

OK - can we assert on one side, perhaps? *shrug* Anyway, whatever
works/suits.


>
> --
> Sergey
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150508/e9a9ce1b/attachment.html>