[PATCH] [StatepointLowering] Don't create temporary instructions. NFCI.

Sanjoy Das sanjoy at playingwithpointers.com
Wed May 6 10:55:59 PDT 2015


On Wed, May 6, 2015 at 10:12 AM, Pat Gavlin <pagavlin at microsoft.com> wrote:
> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/StatepointLowering.cpp:277
> @@ -276,3 @@
> -  // after we delete this node.
> -  Builder.removeValue(Tmp);
> -  delete Tmp;
> ----------------
> Can SelectionDAGBuilder::removeValue be removed now that this code no longer uses it? AFAICT this is the only user of that method (indeed, a comment inside that method indicates as much).

Thanks for catching this!  I'll remove it.

-- Sanjoy

>
> http://reviews.llvm.org/D9480
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list