[PATCH] Don't try to emit loopVectorize warning if DebugLoc isn't available

Geoff Berry gberry at codeaurora.org
Mon May 4 10:46:02 PDT 2015


Coincidentally, I just submitted a patch to do this in clang:

http://reviews.llvm.org/D9449

--
Geoff Berry
Employee of Qualcomm Innovation Center, Inc.
 Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Davide Italiano
Sent: Sunday, May 03, 2015 1:55 AM
To: dccitaliano at gmail.com; nrotem at apple.com; dexonsmith at apple.com
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Don't try to emit loopVectorize warning if DebugLoc
isn't available

In http://reviews.llvm.org/D9463#165235, @dexonsmith wrote:

> Would it be better to make emitOptimizationRemarkMissed() resilient to a
null DebugLoc?   It seems strange to require debug info to print pass
remarks.


emitLoopVectorizeWarning() should actually be made resilient because that's
where the crash happen.
I'll take a look at this further tomorrow.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9463

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list