[PATCH] Move getX86SubSuperRegister to a new X86RegisterUtils file

Pete Cooper peter_cooper at apple.com
Mon Apr 20 14:49:48 PDT 2015


Should have said that this depends on http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150420/272245.html <http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150420/272245.html>.

I’m happy to wait until that patch has landed before we discuss this one, if that makes sense.

Cheers,
Pete
> On Apr 20, 2015, at 2:48 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> 
> Hi Quentin, Evgeniy
> 
> X86AsmInstrumentation.cpp uses a method in X86 CodeGen called getX86SubSuperRegister.
> 
> This patch creates a new file in X86 Utils for register utilities such as this method.  This breaks a cycle between the MC layer AsmInstrumentation, and the CodeGen layer.
> 
> Bike shedding welcome on the name of the file as well as its location. Targets don’t explicitly have an MC directory, so Utils seemed to make sense, but i’m happy to move it elsewhere.
> 
> Cheers,
> Pete
> 
> <x86-register-utils.diff>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150420/aef115e1/attachment.html>


More information about the llvm-commits mailing list