<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Should have said that this depends on <a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150420/272245.html" class="">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150420/272245.html</a>.<div class=""><br class=""></div><div class="">I’m happy to wait until that patch has landed before we discuss this one, if that makes sense.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Pete<br class=""><div><blockquote type="cite" class=""><div class="">On Apr 20, 2015, at 2:48 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi Quentin, Evgeniy<br class=""><br class="">X86AsmInstrumentation.cpp uses a method in X86 CodeGen called getX86SubSuperRegister.<br class=""><br class="">This patch creates a new file in X86 Utils for register utilities such as this method. This breaks a cycle between the MC layer AsmInstrumentation, and the CodeGen layer.<br class=""><br class="">Bike shedding welcome on the name of the file as well as its location. Targets don’t explicitly have an MC directory, so Utils seemed to make sense, but i’m happy to move it elsewhere.<br class=""><br class="">Cheers,<br class="">Pete<br class=""><br class=""><span id="cid:3944884D-BC83-427B-9B1D-766EE26939D5@apple.com"><x86-register-utils.diff></span></div></blockquote></div><br class=""></div></body></html>