[PATCH] COFF: Let globals with private linkage reside in their own section

David Majnemer david.majnemer at gmail.com
Tue Mar 17 16:11:25 PDT 2015


================
Comment at: include/llvm/IR/DataLayout.h:264
@@ -255,2 +263,3 @@
+      return "";
     return getPrivateGlobalPrefix();
   }
----------------
rafael wrote:
> Given the discussion of making this "the closest to private that the linker still sees", this should probably return "" on all  non-macho.
Done.

================
Comment at: test/CodeGen/ARM/Windows/long-calls.ll:13
@@ -12,3 +12,3 @@
 ; CHECK-LABEL: caller
-; CHECK: ldr [[REG:r[0-9]+]], [[CPI:.LCPI[_0-9]+]]
+; CHECK: ldr [[REG:r[0-9]+]], [[CPI:LCPI[_0-9]+]]
 ; CHECK: bx [[REG]]
----------------
rafael wrote:
> This is a bug fix, right? The old .L prefix would actully be visible but the L one is not?
> 
It was necessary to fix because ARM and 64-bit x86 were not using MM_WinCOFF, they were using the ELF mangling.

http://reviews.llvm.org/D8394

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list