[PATCH] COFF: Let globals with private linkage reside in their own section

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Mar 17 15:40:07 PDT 2015

Comment at: include/llvm/IR/DataLayout.h:264
@@ -255,2 +263,3 @@
+      return "";
     return getPrivateGlobalPrefix();
Given the discussion of making this "the closest to private that the linker still sees", this should probably return "" on all  non-macho.

Comment at: test/CodeGen/ARM/Windows/long-calls.ll:13
@@ -12,3 +12,3 @@
 ; CHECK-LABEL: caller
-; CHECK: ldr [[REG:r[0-9]+]], [[CPI:.LCPI[_0-9]+]]
+; CHECK: ldr [[REG:r[0-9]+]], [[CPI:LCPI[_0-9]+]]
 ; CHECK: bx [[REG]]
This is a bug fix, right? The old .L prefix would actully be visible but the L one is not?



More information about the llvm-commits mailing list