[patch][R600] Call EmitFunctionHeader just before EmitFunctionBody.
tom at stellard.net
Tue Mar 17 07:35:19 PDT 2015
On Mon, Mar 16, 2015 at 07:30:28PM -0400, Rafael Espíndola wrote:
> It is a pretty simple patch.
Echoing what I said on IRC: LGTM.
> On 11 March 2015 at 14:49, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> > Hi Tom,
> > Currently R600 is the only backend whose call to EmitFunctionHeader is
> > not just before EmitFunctionBody. Looking at the code history I think
> > this is an unintended consequence from when R600 had a more custom
> > syntax and didn't even call EmitFunctionHeader.
> > The attached t1.patch changes that and updates the tests to check for
> > the new order.
> > The reason for doing so is that it allows EmitFunctionHeader to be
> > just a private helper (see t2.patch) which reduces code duplication
> > and helps with another patch I am working on.
> > Cheers,
> > Rafael
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
More information about the llvm-commits