[patch][R600] Call EmitFunctionHeader just before EmitFunctionBody.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Mar 16 16:30:28 PDT 2015


Ping.

It is a pretty simple patch.

On 11 March 2015 at 14:49, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> Hi Tom,
>
> Currently R600 is the only backend whose call to EmitFunctionHeader is
> not just before EmitFunctionBody. Looking at the code history I think
> this is an unintended consequence from when R600 had a more custom
> syntax and didn't even call EmitFunctionHeader.
>
> The attached t1.patch changes that and updates the tests to check for
> the new order.
>
> The reason for doing so is that it allows EmitFunctionHeader to be
> just a private helper (see t2.patch) which reduces code duplication
> and helps with another patch I am working on.
>
> Cheers,
> Rafael




More information about the llvm-commits mailing list