[PATCH] asan: do not instrument direct inbounds accesses to stack variables
dberlin at dberlin.org
Tue Mar 3 17:04:33 PST 2015
On Wed, Mar 4, 2015 at 11:55 AM, Chandler Carruth <chandlerc at gmail.com>
> This looks very good to me as well. I think you can submit now. The
> remaining issues are I think quite minor.
> However, I would love to find some form of naming that doesn't so easily
> confuse the GEP "inbounds" keyword with this check. Sadly, I can't come up
> with any good ideas. Maybe just talk about "safe" in the APIs and explain
> what the object size check is computing, etc.? Anyways, a minor point.
> If this causes a compile-time regression, it should be easy to track down.
> You might do a quick sanity check for some big inputs Dmitry, since it
> seems like you have them.
> Danny, I'm pretty sure that the object size code is newer and should at
> least in theory be more powerful than just getting the base address. I
> could be wrong though. Still, easy to switch to that in a follow-up if
I may see about switching GVN in the other direction then, gotta see what
the cost is :)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits