[PATCH] [MC] Implement support for R_X86_64_SIZE64

Davide Italiano davide at freebsd.org
Mon Mar 2 23:47:18 PST 2015

In http://reviews.llvm.org/D7990#133276, @majnemer wrote:

> In http://reviews.llvm.org/D7990#133275, @majnemer wrote:
> > Seems a little over specific, it would be nice if we could handle `R_386_SIZE32` and `R_X86_64_SIZE32` as well.
> Arg, this feedback isn't very helpful.  Sorry about that.  I guess what I tried to communicate was that we should have a `VK_SIZE` instead of `VK_X86_64_SIZE` and let the fixup's kind govern whether we get ``R_X86_64_SIZE32` or ``R_X86_64_SIZE64`.

Thank for the review. This was my intention actually, and I think your comment is a sign that I chose the wording poorly.
Let me rephrase. It seems to me the format for VK is VK_<$arch | $format >_<$identifier>.
A couple of examples of this are, e.g. VK_Mips_HIGHEST and VK_COFF_IMGREL32
In other words, X86_64 doesn't refer to the size but the target architecture. We can use something else if you have a better proposition.




More information about the llvm-commits mailing list