[PATCH] Have a way to let fast-isel handle normally optimized library functions

reed kotler rkotler at mips.com
Mon Mar 2 10:32:52 PST 2015

The normal selection mechanism would work fine but current hack in 
fast-isel prevents it.

The selection mechanism should call the FastInstrinsciCall to do this.

Then it would be up to the individual port whether to ignore it.

So we could delete the following lines from selectInstruction:

     // As a special case, don't handle calls to builtin library functions that
     // may be translated directly to target instructions.
     if (F && !F->hasLocalLinkage() && F->hasName() &&
         LibInfo->getLibFunc(F->getName(), Func) &&
       return false;

On 03/02/2015 09:55 AM, Eric Christopher wrote:
> Hi Reed,
> Not such a huge fan of this patch, I'd rather just do this independently by having the selection mechanism just handle the functions. How were you planning on implementing aspects of this and why wouldn't it just work in general?
> Thanks!
> -eric
> http://reviews.llvm.org/D7397
>    http://reviews.llvm.org/settings/panel/emailpreferences/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150302/a4fdf0db/attachment.html>

More information about the llvm-commits mailing list