<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">The normal selection mechanism would
work fine but current hack in fast-isel prevents it.<br>
<br>
The selection mechanism should call the FastInstrinsciCall to do
this.<br>
<br>
Then it would be up to the individual port whether to ignore it.<br>
<br>
So we could delete the following lines from selectInstruction:<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; white-space: pre-wrap;"><meta http-equiv="content-type" content="text/html; charset=utf-8"> // As a special case, don't handle calls to builtin library functions that
// may be translated directly to target instructions.
if (F && !F->hasLocalLinkage() && F->hasName() &&
LibInfo->getLibFunc(F->getName(), Func) &&
LibInfo->hasOptimizedCodeGen(Func))
return false;
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; white-space: pre-wrap;"></pre></pre>
<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<span style="color: rgb(20, 24, 35); font-family: Helvetica,
Arial, 'lucida grande', tahoma, verdana, arial, sans-serif;
font-size: 14px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
19.3199996948242px; orphans: auto; text-align: left;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;
display: inline !important; float: none; background-color:
rgb(255, 255, 255);"></span><br>
On 03/02/2015 09:55 AM, Eric Christopher wrote:<br>
</div>
<blockquote
cite="mid:6b5ceecba886e886283b2614fd4ce736@localhost.localdomain"
type="cite">
<pre wrap="">Hi Reed,
Not such a huge fan of this patch, I'd rather just do this independently by having the selection mechanism just handle the functions. How were you planning on implementing aspects of this and why wouldn't it just work in general?
Thanks!
-eric
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D7397">http://reviews.llvm.org/D7397</a>
EMAIL PREFERENCES
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a>
</pre>
</blockquote>
<br>
</body>
</html>