[PATCH] Make DataLayout Non-Optional in the Module

Eric Christopher echristo at gmail.com
Mon Mar 2 09:40:54 PST 2015

Few small comments:

a) You've got Function::getDataLayout - I think I'd prefer people to generally have to ask the Function parent to get the data layout. (It's also a little inconsistent in the code, but should be fairly sed'able).

b) Routines to construct a data layout (Totally a follow up patch) in llvm rather than requiring each front end to handle construct them up themselves.

c) Relatedly you don't do anything about the code in the backends that constructs the data layouts?




More information about the llvm-commits mailing list