[PATCH] Mangler: Don't prefix MS ABI names with a leading ? character

Reid Kleckner rnk at google.com
Fri Feb 20 09:57:44 PST 2015

In http://reviews.llvm.org/D7775#127101, @rafael wrote:

> This would change the result of
> @"?foo" = private global  i32 42
> no? In particular it would miss the .L on ELF.

Yes. The lack of .L is concerning, but why have we been able to get by without the L prefix on COFF for so long with these names? Is there a bug there too? Maybe we should do the private symbol prefixing even in the presence of '?' or '\01'?



More information about the llvm-commits mailing list