[PATCH] Mangler: Don't prefix MS ABI names with a leading ? character

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Thu Feb 19 17:47:47 PST 2015


This would change the result of

@"?foo" = private global  i32 42

no? In particular it would miss the .L on ELF.


================
Comment at: lib/IR/Mangler.cpp:118
@@ -117,1 +117,3 @@
 
+  // Don't mangle Microsoft C++ names, which start with '?'.
+  if (Name.startswith("?")) {
----------------
You can move this before " Prefix = ..";

http://reviews.llvm.org/D7775

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list