[PATCH] [ELF] Implement --stats

[Rui Ueyama]

LGTM


REPOSITORY
  rL LLVM

================
Comment at: lib/Driver/GnuLdDriver.cpp:181
@@ +180,3 @@
+    diag << "total time in link " << t.getProcessTime() << "\n";
+    diag << "data size " << t.getMemUsed() << "\n";
+  }
----------------
davide wrote:
> ruiu wrote:
> > total -> Total
> > 
> > "data size" may be confusing -- this can be read as the total number of bytes read from disk, for example. Needs a bit of wordsmithing.
> > 
> This is what GNU ld uses. I agree with you it's a poorly chosen sequence of words, so we need to decide if we want to stick with what they currently output or introduce our own notion of statistics. At this point I can also say that we can output something more meaningful/fine-grained.
> Considering this isn't a very common option for ld(1) we can probably go for the path of breaking compatibility but I would like to have a more detailed discussion about it before taking any actions.
Ah, it's okay then. It's better to keep the same wording as the GNU linker if there's no reason to change them. I'm also okay to keep it for the GNU driver only for now as we don't know what command line option should be used to enable this feature for other drivers. (For PE/COFF, it should be enabled when /verbose is given? Perhaps. But I don't know.) It's pretty easy to move this to Driver in future.

http://reviews.llvm.org/D7657

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/