[PATCH] [ELF] Implement --stats

Davide Italiano davide at freebsd.org
Thu Feb 19 15:56:33 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Driver/GnuLdDriver.cpp:181
@@ +180,3 @@
+    diag << "total time in link " << t.getProcessTime() << "\n";
+    diag << "data size " << t.getMemUsed() << "\n";
+  }
----------------
ruiu wrote:
> total -> Total
> 
> "data size" may be confusing -- this can be read as the total number of bytes read from disk, for example. Needs a bit of wordsmithing.
> 
This is what GNU ld uses. I agree with you it's a poorly chosen sequence of words, so we need to decide if we want to stick with what they currently output or introduce our own notion of statistics. At this point I can also say that we can output something more meaningful/fine-grained.
Considering this isn't a very common option for ld(1) we can probably go for the path of breaking compatibility but I would like to have a more detailed discussion about it before taking any actions.

http://reviews.llvm.org/D7657

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list